Fix bug of empty input in gelu.cu #800
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #800 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 84 84
Lines 6588 6588
=======================================
Hits 4873 4873
Misses 1715 1715 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Devel update
Member
|
Is our gelu much faster than TensorFlow's (tensorflow/tensorflow#41178)? It seems that they implement gelu only using some python codes. See https://github.com/tensorflow/tensorflow/blob/v2.5.0/tensorflow/python/ops/nn_ops.py#L3505-L3548 |
njzjz
approved these changes
Jun 26, 2021
Member
Yes, that's why we implement gelu by ourselves |
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 2, 2021
* add gpu op unittest in source/tests * fix bug in deepmodeling#713 * Fix bug of empty input in gelu.cu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#675 and #742 maybe the same bugs when:
this causes the empty input in gelu.cu and thus breaks.